Skip to content

Conversation

Sicheng-Pan
Copy link
Contributor

@Sicheng-Pan Sicheng-Pan commented Oct 10, 2025

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Replace usage of get_range with get_prefix
  • New functionality
    • N/A

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Migration plan

Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?

Observability plan

What is the plan to instrument and monitor this change?

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the _docs section?_

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@Sicheng-Pan Sicheng-Pan marked this pull request as ready for review October 10, 2025 21:53
Copy link
Contributor

Optimize FTS by Replacing get_range with get_prefix in Full Text Search

This pull request improves the Full Text Search (FTS) functionality in the rust/index/src/fulltext/types.rs module by replacing usages of the get_range method with the more efficient get_prefix method for blockfile reads. This change is scoped to several call sites within token/posting list lookup and affects the retrieval and processing logic in both the main FTS search and associated utility/test functions. Minor additional corrections are made to tuple field unpacking and mapping, aligning the data access pattern with the slightly changed result shape from get_prefix.

Key Changes

• Replaced all instances of .get_range with .get_prefix in FullTextIndexReader.
• Adjusted iteration and map logic to reflect the tuple changes from using get_prefix (for example, adjusting from .1/.2 to .0/.1 as necessary).
• Updated tests/utilities for correct retrieval and processing under the new method.

Affected Areas

rust/index/src/fulltext/types.rs (Full Text Index Reader and related utilities)

This summary was automatically generated by @propel-code-bot

@Sicheng-Pan Sicheng-Pan merged commit bd4398d into main Oct 15, 2025
63 checks passed
@Sicheng-Pan Sicheng-Pan deleted the 10-10-_enh_optimize_fts branch October 15, 2025 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants